From bdd2a43c8b3e79eec20579592fe179f7fcc1ddd1 Mon Sep 17 00:00:00 2001
From: Yaro Kasear <git@kasear.net>
Date: Mon, 16 Jun 2025 16:24:41 -0500
Subject: [PATCH] Refactor worklog handling and table rendering in templates
 for improved clarity and performance

---
 routes.py                                | 23 ++++++++++------------
 templates/fragments/_table_fragment.html | 25 +++++++++++++++++++-----
 templates/index.html                     | 18 ++++++-----------
 templates/inventory.html                 | 13 +-----------
 templates/layout.html                    | 17 ++--------------
 templates/table.html                     |  2 +-
 6 files changed, 40 insertions(+), 58 deletions(-)

diff --git a/routes.py b/routes.py
index f8794e8..d19a1ab 100644
--- a/routes.py
+++ b/routes.py
@@ -131,7 +131,6 @@ def render_paginated_table(
 
 @main.route("/")
 def index():
-    stale_worklog_page = request.args.get('stale_worklog_page', 1, int)
     cutoff = datetime.utcnow() - timedelta(days=14)
 
     worklog_query = eager_load_worklog_relationships(
@@ -140,8 +139,9 @@ def index():
         (WorkLog.start_time < cutoff) & (WorkLog.complete == False)
     )
     
-    stale_pagination = make_paginated_data(worklog_query, stale_worklog_page, 3)
-    stale_count = len(worklog_query.all())
+    stale_worklogs = worklog_query.all()
+
+    stale_count = len(stale_worklogs)
     stale_worklog_headers = {
         k: v for k, v in worklog_headers.items()
         if k not in ['End Time', 'Quick Analysis?', 'Complete?', 'Follow Up?']
@@ -182,13 +182,12 @@ def index():
     return render_template(
         "index.html", 
         title="Inventory Manager", 
-        stale_pagination=stale_pagination, 
         stale_count=stale_count, 
         stale_worklog_headers=stale_worklog_headers,
         stale_worklog_rows=[{
             "id": log.id,
             "cells": [fn(log) for fn in stale_worklog_headers.values()]
-        } for log in stale_pagination['items']],
+        } for log in stale_worklogs],
         labels=labels,
         datasets=datasets
     )
@@ -236,17 +235,15 @@ def list_inventory():
         else:
             return "Invalid filter_by parameter", 400
 
+    inventory = query.all()
 
-    return render_paginated_table(
-        query=query,
-        page=page,
+    return render_template(
+        'table.html', 
         title=f"Inventory Listing ({filter_name})" if filter_by else "Inventory Listing",
-        headers=inventory_headers,
-        row_fn=lambda i: [fn(i) for fn in inventory_headers.values()],
-        endpoint="main.list_inventory",
-        entry_route="inventory_item",
         breadcrumb=[{'label': 'Inventory', 'url': url_for('main.inventory_index')}],
-        extra_args={'filter_by': filter_by, 'id': id}
+        header=inventory_headers,
+        rows=[{"id": item.id, "cells": [row_fn(item) for row_fn in inventory_headers.values()]} for item in inventory],
+        entry_route = 'inventory_item'
     )
 
 @main.route("/inventory/index")
diff --git a/templates/fragments/_table_fragment.html b/templates/fragments/_table_fragment.html
index f6e3dd7..0c5d6da 100644
--- a/templates/fragments/_table_fragment.html
+++ b/templates/fragments/_table_fragment.html
@@ -1,8 +1,7 @@
-{% macro render_table(headers, rows, entry_route=None, title=None) %}
+{% macro render_table(headers, rows, id, entry_route=None, title=None, per_page=15) %}
 {% if rows %}
 <div class="table-responsive">
-    <table
-        id="datatable-{{ title|default('table')|replace(' ', '-')|lower }}"
+    <table id="datatable-{{ id|default('table')|replace(' ', '-')|lower }}"
         class="table table-bordered table-sm table-hover table-striped table-light m-0{% if title %} caption-top{% endif %}">
         {% if title %}
         <caption>{{ title }}</caption>
@@ -34,13 +33,29 @@
         </tbody>
     </table>
 </div>
+
+<script>
+    document.addEventListener("DOMContentLoaded", function () {
+        {# console.log($('table[id="datatable-{{ id|default('table')|replace(' ', '-')|lower }}"]'))
+        $('table[id="datatable-{{ id|default('table')|replace(' ', '-')|lower }}"]').DataTable({
+            pageLength: {{ per_page }},
+            lengthChange: false,
+            ordering: true,
+            stateSave: true
+        }) #}
+        new DataTable('#datatable-{{ id|default('table')|replace(' ', '-')|lower }}', {
+            pageLength: {{ per_page }},
+            colReorder: true
+        })
+    })
+</script>
 {% else %}
 <div class="container text-center">No data.</div>
 {% endif %}
 {% endmacro %}
 
 {% macro render_pagination(endpoint, page, has_prev, has_next, total_pages, page_variable='page', extra_args={}) %}
-{% set prev_args = extra_args.copy() %}
+{# % set prev_args = extra_args.copy() %}
 {% set next_args = extra_args.copy() %}
 {% set first_args = extra_args.copy() %}
 {% set last_args = extra_args.copy() %}
@@ -78,5 +93,5 @@
             class="btn btn-primary{% if not has_next %} disabled{% endif %}">Last &raquo;</a>
     </div>
 </div>
-{% endif %}
+{% endif % #}
 {% endmacro %}
\ No newline at end of file
diff --git a/templates/index.html b/templates/index.html
index 0f08b08..789ba57 100644
--- a/templates/index.html
+++ b/templates/index.html
@@ -8,7 +8,7 @@
     <h1 class="display-4">Welcome to Inventory Manager</h1>
     <p class="lead">Find out about all of your assets.</p>
     <div class="row">
-        {% if stale_pagination['items'] %}
+        {% if stale_worklog_rows %}
         <div class="col">
             <div class="card">
                 <div class="card-body">
@@ -16,17 +16,11 @@
                     <h6 class="card-subtitle mb-2 text-body-secondary">You have {{ stale_count }} worklogs
                         that need attention!</h6>
                     {{ tables.render_table(
-                    stale_worklog_headers,
-                    stale_worklog_rows,
-                    'worklog_entry'
-                    )}}
-                    {{ tables.render_pagination(
-                    'index',
-                    stale_pagination['page'],
-                    stale_pagination['has_prev'],
-                    stale_pagination['has_next'],
-                    stale_pagination['total_pages'],
-                    page_variable='stale_worklog_page'
+                        headers = stale_worklog_headers,
+                        rows = stale_worklog_rows,
+                        id = 'Stale Worklog',
+                        entry_route = 'worklog_entry',
+                        per_page = 3
                     )}}
                 </div>
             </div>
diff --git a/templates/inventory.html b/templates/inventory.html
index 449dcf1..f8db952 100644
--- a/templates/inventory.html
+++ b/templates/inventory.html
@@ -124,18 +124,7 @@ submit_button=True) }}
             </div>
             {% if worklog %}
             <div class="col-6">
-                {{ tables.render_table(worklog_headers, worklog_rows, 'worklog_entry', 'Work Log') }}
-                {% if worklog_pagination['total_pages'] > 1 %}
-                {{ tables.render_pagination(
-                page=worklog_pagination['page'],
-                has_prev=worklog_pagination['has_prev'],
-                has_next=worklog_pagination['has_next'],
-                total_pages=worklog_pagination['total_pages'],
-                endpoint='main.inventory_item',
-                page_variable='worklog_page',
-                extra_args={'id': item.id, 'worklog_page': worklog_page, 'filter_by': filter_by, 'id': id}
-                ) }}
-                {% endif %}
+                {{ tables.render_table(headers=worklog_headers, rows=worklog_rows, id='worklog', entry_route='worklog_entry', title='Work Log') }}
             </div>
             {% endif %}
         </div>
diff --git a/templates/layout.html b/templates/layout.html
index ded6e3e..a04bff2 100644
--- a/templates/layout.html
+++ b/templates/layout.html
@@ -18,9 +18,7 @@
         rel="stylesheet" integrity="sha384-gdnBcErvPbrURVoR9w3NhVMliw+ZmcTCmq+64xj2Ksx21nRJFX3qW0zFvBotL5rm"
         crossorigin="anonymous">
     <style>
-        {
-            % block style %
-        }
+        {% block style %}
 
         .sticky-top {
             position: sticky;
@@ -47,9 +45,7 @@
             background-color: white;
         }
 
-            {
-            % endblock %
-        }
+            {% endblock %}
     </style>
 </head>
 
@@ -96,15 +92,6 @@
         searchInput.addEventListener('input', () => {
             searchButton.disabled = searchInput.value.trim() === '';
         });
-
-        document.addEventListener("DOMContentLoaded", function () {
-            $('table[id^="datatable-"]').DataTable({
-                pageLength: 25,
-                lengthChange: false,
-                ordering: true,
-                stateSave: true
-            })
-        })
         {% block script %} {% endblock %}
     </script>
 </body>
diff --git a/templates/table.html b/templates/table.html
index 8000d66..4bc2092 100644
--- a/templates/table.html
+++ b/templates/table.html
@@ -10,6 +10,6 @@
     breadcrumbs=breadcrumb
 ) }}
 
-{{ tables.render_table(header, rows, entry_route) }}
+{{ tables.render_table(headers=header, rows=rows, id=title, entry_route=entry_route) }}
 {# { tables.render_pagination(endpoint, page, has_prev, has_next, total_pages, extra_args=extra_args) } #}
 {% endblock %}
\ No newline at end of file