From df05194b3beb86f169204f1f7a6b9b45f50d2e5a Mon Sep 17 00:00:00 2001 From: Yaro Kasear Date: Mon, 5 May 2025 14:39:03 -0500 Subject: [PATCH 1/2] Initialize duration variables for speed test metrics --- runtest.sh | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/runtest.sh b/runtest.sh index 03b2d82..a3b9c45 100755 --- a/runtest.sh +++ b/runtest.sh @@ -184,6 +184,16 @@ for ((COUNTER = 1; COUNTER <= NUM_TESTS; COUNTER++)); do bssid_and_bitrate=$(iw dev "$INTERFACE" link | awk '/Connected/ {bssid=$3} /tx bitrate/ {tx=$3} /rx bitrate/ {rx=$3} END {print bssid","tx","rx}') speed_results="" + speedtest_duration=0 + localtcpup_duration=0 + localtcpdown_duration=0 + localudpup_duration=0 + localudpdown_duration=0 + remotetcpup_duration=0 + remotetcpdown_duration=0 + remoteudpup_duration=0 + remoteudpdown_duration=0 + for ((retry = 1; retry <= MAX_RETRIES; retry++)); do SECONDS=0 log "Speed test attempt $retry" From 89dd1e030e9954d5e4da2b1418f5190116a537f2 Mon Sep 17 00:00:00 2001 From: Yaro Kasear Date: Mon, 5 May 2025 14:39:28 -0500 Subject: [PATCH 2/2] Fix variable assignment for speedtest duration tracking --- runtest.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/runtest.sh b/runtest.sh index a3b9c45..44d83c9 100755 --- a/runtest.sh +++ b/runtest.sh @@ -198,7 +198,7 @@ for ((COUNTER = 1; COUNTER <= NUM_TESTS; COUNTER++)); do SECONDS=0 log "Speed test attempt $retry" speed_results=$(speedtest --secure --csv 2>/dev/null || true) - $speedtest_duration=$SECONDS + speedtest_duration=$SECONDS [[ -n "$speed_results" ]] && break warn "Speedtest failed. Retrying in $RETRY_DELAY seconds..." echo "$(date -Iseconds),Speedtest failed on attempt $retry for test $COUNTER, sample $i" >> "$FAILURE_LOG" @@ -209,7 +209,7 @@ for ((COUNTER = 1; COUNTER <= NUM_TESTS; COUNTER++)); do timestamp=$(date -Iseconds) warn "Speedtest permanently failed. Skipping sample." echo "$timestamp,Test $COUNTER,Sample $i" >>"$FAILURE_LOG" - $speedtest_duration=$SECONDS + speedtest_duration=$SECONDS continue fi